-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade osgi jdbc add tck #2066
Conversation
@Jeffery-Wasty I don't really understand how to get more details about the testfailure can you give me a hint? |
@laeubi, we'll have to look into this. Previously the errors were caused by |
Can you please confirm for us the necessity and use of the test? Is implementation of this test required by spec, or is this just a confirmation that the properties have been added correctly. It looks like the issues are all caused by the added test, so if it can be omitted, that would help us. |
It is not strictly required, this just ensures that the implementation is fulfilling the spec. |
Thanks for the explanation. We're still looking into it, its not readily apparent from the logs why this is failing, but we'll keep you updated on progress regarding this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @laeubi, The issue is that the test is that its using Junit5, and when this is invoked, causes issues in other tests in the project. If the tests can be rewritten only using features of Junit4 or below, that will allow it to pass and be included as part of the changes. Comparing the test styles from this PR and #2017, I think the one in 2017 fits the project better, as opposed to the additional test information in the pom. Let's move forward with 2017 being the only PR for this change. We'll close the others, but thank you for this layered approach, it really helped in narrowing down on the problem. |
This includes: